Refactor PaymentSheet didSelectPayWithLink delegate flow #3571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not actually sure this is better, changing to draft |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Cleaner if PaymentSheetViewController is responsible for this - it can clear its text fields, hide the keyboard etc. when Link payment starts. Will make it cleaner for Vertical mode, too, since it will do different things (no text fields to clear or keyboard to hide).
Testing
Manually tested Link animations
Simulator.Screen.Recording.-.snapshot.tester.iPhone.12.mini.16.4.-.2024-05-08.at.11.24.48.mp4
Changelog
Not user facing